Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Dispose Issue #7

Merged
merged 1 commit into from
Feb 1, 2021
Merged

Bugfix: Dispose Issue #7

merged 1 commit into from
Feb 1, 2021

Conversation

schillingdavid
Copy link
Contributor

Fixed an issue with the disposing of the animation controller which could cause memory leaks and crashes.

Fixed an issue with the disposing of the animation controller which could cause memory leaks and crashes.
@schillingdavid
Copy link
Contributor Author

Fixes the following exception:

The following assertion was thrown while finalizing the widget tree:
_FlutterPasswordStrengthState#61795(ticker active) was disposed with an active Ticker.

_FlutterPasswordStrengthState created a Ticker via its SingleTickerProviderStateMixin, but at the time dispose() was called on the mixin, that Ticker was still active. The Ticker must be disposed before calling super.dispose().

Tickers used by AnimationControllers should be disposed by calling dispose() on the AnimationController itself. Otherwise, the ticker will leak.

@volmus
Copy link

volmus commented Nov 25, 2020

Any news on this @JinHoSo ?

@JinHoSo
Copy link
Owner

JinHoSo commented Feb 1, 2021

@schillingdavid Thank you 🙏

@JinHoSo JinHoSo merged commit 1bef5e1 into JinHoSo:master Feb 1, 2021
@schillingdavid
Copy link
Contributor Author

@schillingdavid Thank you 🙏

Of course! 😊 Do you plan on tagging a new release real soon? 😊 If so, what do you think when? 😬

@arielt
Copy link

arielt commented Dec 6, 2021

Hi , looks like the fix was reverted in one of the later commits: d28089d
Any chance to restore it?
The issue with the Ticker is seen again.

@schillingdavid
Copy link
Contributor Author

Hi , looks like the fix was reverted in one of the later commits: d28089d Any chance to restore it? The issue with the Ticker is seen again.

Yeah, it really was reverted. I added a new Pull Request #17.
It'll be merged after @JinHoSo reviewed and accepted it. 😊

@arielt
Copy link

arielt commented Feb 10, 2022

Checking back, I think it is still a useful fix.

@robyf
Copy link

robyf commented Mar 23, 2023

Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants