Add supports for RN 0.71 #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried it on android RN 0.71, did not work, started receiving errors of different classes are defined multiple times. Tried cleaning and rebuilding project which did not help, after removing clusterer from deps, everything went back to normal |
|
I can confirm that this fix still has some issues on my end as well. Though it's a good starting point. Currently this lib is blocking the upgrade for me. |
|
@focux @teeserted @JiriHoffmann I made a PR in @focux 's fork that makes it work more consistently for me. Can you guys test/validate this? |
|
@JoniVR Thanks to your work my android version is now building and clustering seems to work. (RN 71.1) |
This was referenced Feb 23, 2023
|
Merged. Thanks for the contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from version 0.71, react native is not shipping the android folder (read more).
This library depends on the⚠️ This is a breaking change.
androidfolder to build correctly, so this PR adds support for 0.71 and above and it's not backward compatible with older versions.Changes: