-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera intrinsic calibration validation #51
Merged
marip8
merged 16 commits into
Jmeyer1292:master
from
marip8:feature/camera_intrinsic_calibration_validation
Jun 24, 2020
Merged
Camera intrinsic calibration validation #51
marip8
merged 16 commits into
Jmeyer1292:master
from
marip8:feature/camera_intrinsic_calibration_validation
Jun 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
@schornakj @colin-lewis-19 can you review this? |
f5c6fe1
to
6cdc4bb
Compare
@schornakj this is ready for review when you get the chance |
schornakj
approved these changes
Jun 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
rct_optimizations/src/rct_optimizations/validation/camera_intrinsic_calibration_validation.cpp
Show resolved
Hide resolved
6824132
to
ddbc1f0
Compare
…eated from a single target
ffe8e4f
to
d2e52a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds capability for validating the accuracy of a camera intrinsic calibration.
Assumptions
Given a set of camera intrinsic parameters and a set of observations:
Results with the data set in
rct_examples
Using Kinect camera estimated intrinsic parameters
This means that the upper bound (mean + 2 sigma) of the transform error from one virtual correspondence set to the other was 25.7 mm and 4.64 degrees (i.e. really bad)
Using Kinect camera calibrated intrinsic parameters
This means that the upper bound (mean + 2 sigma) of the transform error from one virtual correspondence set to the other was 17.5 mm and 4.07 degrees (i.e. still pretty bad)
These results along with @schornakj 's covariance analysis in #46 seem to show that there was probably a lack of data diversity in these images. We should eventually create a data set of really good intrinsic calibration images with which to run this test.