-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed property "name" on LoxoneCustomerSensor #268
Conversation
@jluthiger what error do you get? The name property is already given in the base class and is not needed in the custom sensor class. |
This is the error:
But the property
The same error would I expect for |
Comment to the background tasks fix. HA complains on startup with:
I made a fix to prevent this blocking call. Please check carefully, if no side-effect will be introduced. I cannot estimate all the consequences. |
@jluthiger I included your request. But I never got this blocking messages. So please check the lastest master branch before I make another version. I changed the CustomSensor implementation. We should use the _attributes and not override the functions. I wrote all this long time ago before homeassistant had this very useful attributes. This can be updated in all places but as I already mentioned I work on a complete different branch at the moment and all renaming and cleanups must be transferred to the other branch (not public) so at the moment it is better only concentrate on the real issues. Thanks for your help. |
Great. Just checked the master branch. Works perfectly! Thanks a lot. |
Version 0.6.7 does not work. I have realized that I have not inserted my fixes properly into my master branch. Here follows the rest. Sorry!
This one is tested against home assistant core 2024.5.0 (and 2024.6.0.dev0).