Update PdfPage.java

[ouani]

Hey,

First of all, thanks a lot for that tremendous component you provided.

I ran into a regular crash when i was using the component to display various pdf file : on the left pane the name of the file and when the user click on a name, the pdf is displayed on the right.

Switching quickly between files to display led me into a RunTimeException in the function :

static PdfPage createPage(long dochandle, int pageno)
{
return new PdfPage(open(dochandle, pageno), dochandle);
}

in org.vudroid.pdfdroid.codec.PdfPage

A little investigation led me to find that this happened when two threads was calling this function at the same time.

Just added a "synchronized" qualifier on the function and that bug was gone.

[JoanZapata]

I already know about concurrency issues but pdfview is supposed to take care of that using a worker thread to render all pdf pages. So you spotted a bug.

Using synchronized would slow down this thread so I would rather not use it, but instead understand why the component created 2 worker threads.

[ouani]

Rodger :) !

[JoanZapata]

Are you using multiple PDFView or reusing one?

[ouani]

Reusing one. I've tried forcing recycle between two .fromFile, setting the View to Null and finding it again. No change. When i switch between file at a slow rate, the problem doesn't occur.

[RoelRoel]

Is there a way to completly kill the PDFview before loading a new PDF file as a work-around?
Wil removing the view from the parent and re-adding it help?

edit: It seems to work for me! :-)

[nrallakis]

Thank you RoelRoel for your tip!
I had been struggling with this problem!
Recycling the pdfview onSaveInstanceState solved it!