Move the watcher cli application to be a go routine #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
iblancasa
commented
May 8, 2024
main.go
Outdated
| return err | ||
| } | ||
|
|
||
| disableReconciliation := os.Getenv("DISABLE_RECONCILIATION") |
There was a problem hiding this comment.
Maybe this can be a CLI option. I think this can be interesting to do for testing reasons.
There was a problem hiding this comment.
Did you run into a use-case where you needed this feature? If we keep it I would change it to DISABLE_WATCHER_CONTROLLER. I'm fine with moving it to CLI option if we want to keep it
main.go
Outdated
| return err | ||
| } | ||
|
|
||
| disableReconciliation := os.Getenv("DISABLE_RECONCILIATION") |
There was a problem hiding this comment.
Did you run into a use-case where you needed this feature? If we keep it I would change it to DISABLE_WATCHER_CONTROLLER. I'm fine with moving it to CLI option if we want to keep it
For testing, for instance. |
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
|
@JoaoBraveCoding added your changes. I think we are ready to merge. |
JoaoBraveCoding
added a commit
that referenced
this pull request
Jun 6, 2024
* feat: addd controller to watch configuration resources * feat: adds controller to annotate ManifestWork * fix: add missing schemas * feat: adds new event handler for cluster wide resources * chore: improves triggers on clusterwideresources * chore: improve enqueueForClusterWideResource function * Add OpenTelemetryCollector resource to the reconciliation Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Revert "Add OpenTelemetryCollector resource to the reconciliation" This reverts commit 0e9894e. * Move the watcher cli application to be a go routine (#12) * Move the watcher cli application to be a go routine Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Fix lint Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Fix lint Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Update internal/controllers/watcher/controller.go Co-authored-by: Joao Marcal <joao.marcal12@gmail.com> * Update internal/controllers/watcher/controller.go Co-authored-by: Joao Marcal <joao.marcal12@gmail.com> * Update main.go Co-authored-by: Joao Marcal <joao.marcal12@gmail.com> * Update main.go Co-authored-by: Joao Marcal <joao.marcal12@gmail.com> * Add suggestion Signed-off-by: Israel Blancas <iblancasa@gmail.com> --------- Signed-off-by: Israel Blancas <iblancasa@gmail.com> Co-authored-by: Joao Marcal <joao.marcal12@gmail.com> * Move to use addon-framework Trigger function (#13) Signed-off-by: Israel Blancas <iblancasa@gmail.com> * revert unrelated changes * * Remove ConfigMaps from reconciliation. * If a secret is updated, check if there is any reference to it in any of the ManifestWorks * Change some comments Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Add changes requested in code review Signed-off-by: Israel Blancas <iblancasa@gmail.com> * Change comment * address small review comments --------- Signed-off-by: Israel Blancas <iblancasa@gmail.com> Co-authored-by: Israel Blancas <iblancasa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
watcherCLI application to be a goroutine.We were discussing this change to avoid the need to create another image as a product.