Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Episode 7 #36

Merged
merged 6 commits into from Apr 8, 2018
Merged

Episode 7 #36

merged 6 commits into from Apr 8, 2018

Conversation

JoaquimLey
Copy link
Owner

  • Implemented the first UI tests for the FavoriteFragment

@JoaquimLey
Initial scaffold SmsController unit tests
1036ac6 
Also added view extension to use Glide to load an drawableId.
@JoaquimLey
Dependency optimization, initial FavoritesViewModel unit tests
5ba1d34 
While writting the first tests I found some hard dependency the  FavoriteViewModel had on the SmsController
it made sense to abstract this class with interface and abstract classes and move the current code to Impl classes.

This way its easier to mock and get more clearer seperation of concerns, this of course is subject to changes.

The modified classes are:
  - SmsBroadcastReceiver to SmsBroadcastReceiverImpl
  - SmsController to SmsControllerImpl
As mentioned above, the original are an abstract class and interface respectivly.

For #29
@JoaquimLey
Initial UI tests for FavoritesFragment
7646963 
For: #29
@JoaquimLey
Create tests related to the Favorite creation
77907b1 
- AlertDialog shown on Fab pressed
- AlertDialog is dismissed when Discard pressed
- AlertDialog shows error when user doesn't input the required BusStop code
- AlertDialog hides error when user starts typing BusStop code

No styling on the views, just basic UI implementation.

For #29
@JoaquimLey
Fix favorites UI tests.
94bb8d2 
For #29
@JoaquimLey JoaquimLey changed the title Stream PR Episode 7 Apr 8, 2018
@JoaquimLey JoaquimLey merged commit babb8d6 into tests/favorites_fragment Apr 8, 2018
@JoaquimLey JoaquimLey deleted the stream/episode_7 branch April 8, 2018 20:43
@JoaquimLey JoaquimLey added this to the MVP milestone Apr 12, 2018
@JoaquimLey JoaquimLey self-assigned this Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoaquimLey JoaquimLey

Labels
Pull-Request: Stream Episode
Projects
None yet
Milestone
Beta 0.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JoaquimLey