Skip to content

Commit

Permalink
Fix home page docs
Browse files Browse the repository at this point in the history 
Fixes #65
  • Loading branch information
@jodastephen
jodastephen committed Mar 28, 2016
1 parent a84c7f9 commit 53cb3dd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/site/markdown/index.md
View file
Expand Up @@ -59,7 +59,7 @@ As a flavour of Joda-Money, here is some example code:

// convert to GBP using a supplied rate
<b>BigDecimal conversionRate = ...; // obtained from code outside Joda-Money</b>

This comment has been minimized.

Sign in to view

Copy link
@whatthefrog

whatthefrog Aug 9, 2016

I would specify that the conversionRate is expected to be given as a multiplier ...

This is a short-coming of your implementation, not a deal breaker though, as one can do the division before calling your method indeed

This comment has been minimized.

Sign in to view

Copy link
@whatthefrog

whatthefrog Aug 9, 2016

Actually the parameter's name mentions it

https://github.com/JodaOrg/joda-money/blob/master/src/main/java/org/joda/money/Money.java#L1209

public Money convertedTo(CurrencyUnit currency, BigDecimal conversionMultipler, RoundingMode roundingMode);
<b>Money moneyGBP = money.convertTo(CurrencyUnit.GBP, conversionRate);</b>
<b>Money moneyGBP = money.convertedTo(CurrencyUnit.GBP, conversionRate, RoundingMode.HALF_UP);</b>

// use a BigMoney for more complex calculations where scale matters
<b><a href="apidocs/org/joda/money/BigMoney.html">BigMoney</a> moneyCalc = money.toBigMoney();</b>
Expand Down

1 comment on commit 53cb3dd

@whatthefrog
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah typo is already fixed it seems, but not yet released to website
http://www.joda.org/joda-money/

Please sign in to comment.