Fixing DataOutputStream usage #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I'm not convinced it is necessary, this will cause no harm. |
jodastephen
added a commit
that referenced
this pull request
Jan 28, 2016
Fixing DataOutputStream usage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a DataOutputStream instance is created, it is a good practice to call flush/close explicitly after finish writing to the stream as mentioned for example here.
Moreover, other places in this project, a close/flush is called on DataOutputStream instance after finish writing to stream for example here.
In the test TestBuilder.java, a DataOutputStream instance wraps an underlying ByteArrayOutputStream instance and invokes the underlying instances's toByteArray() without calling recommended close/flush method.
This pull request adds a flush method at appropriate place and also fix the issue with the test TestBuilder.java as mentioned above. This PR is similar to my earlier accepted PR