Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed downloaded google search #35

Open
wants to merge 1 commit into
base: patch-1
Choose a base branch
from

Conversation

d0codesoft
Copy link

Fixed: added header 'accept' to correctly return google request.
Fided index value structure about information a file, returned google search.
Upgrade library to lasted version urllib3, httplib2.

@copperwiring
Copy link

copperwiring commented Mar 20, 2024

@Joeclinton1 Does this work by pulling your main repo

git clone https://github.com/Joeclinton1/google-images-download.git
cd google-images-download && python setup.py install

or @d0codesoft we need to pull yours?

what are the correct instructions to use the updated version? I used the following:

git clone https://github.com/d0codesoft/google-images-download.git
cd google-images-download
git checkout patch-1
python setup.py install
googleimagesdownload -k "children in park" -l 10

I get


Item no.: 1 --> Item name = children in park
Evaluating...
Starting Download...
'NoneType' object is not subscriptable
Traceback (most recent call last):
  File "/Users/srishtiy/anaconda3/bin/googleimagesdownload", line 33, in <module>
    sys.exit(load_entry_point('google-images-download==2.8.0', 'console_scripts', 'googleimagesdownload')())
  File "/Users/srishtiy/anaconda3/lib/python3.10/site-packages/google_images_download-2.8.0-py3.10.egg/google_images_download/google_images_download.py", line 1167, in main
  File "/Users/srishtiy/anaconda3/lib/python3.10/site-packages/google_images_download-2.8.0-py3.10.egg/google_images_download/google_images_download.py", line 971, in download
  File "/Users/srishtiy/anaconda3/lib/python3.10/site-packages/google_images_download-2.8.0-py3.10.egg/google_images_download/google_images_download.py", line 1119, in download_executor
  File "/Users/srishtiy/anaconda3/lib/python3.10/site-packages/google_images_download-2.8.0-py3.10.egg/google_images_download/google_images_download.py", line 907, in _get_all_items
TypeError: 'NoneType' object is not subscriptable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants