This repository has been archived by the owner on Jan 5, 2021. It is now read-only.
Use .jshintrc relative to file being hinted. #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be merged so bad |
| } | ||
| }); | ||
| if (this.editor) { | ||
| this.unsubscribeEditor(editor); |
There was a problem hiding this comment.
jshint tells me that editor is not defined, i'm assuming it should be this.editor?
|
Once those two code comments are addressed i'm happy to merge this. Great work! It works flawlessly :) |
|
Ok. Fixed. :) I should have spotted those, but my atom-jshint wasn't working at the moment.. :) |
|
So the only problem is that if you rely on |
Joezo
pushed a commit
that referenced
this pull request
Jun 26, 2014
Use .jshintrc relative to file being hinted.
|
Released as 1.3.0 :) https://atom.io/packages/atom-jshint |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a stab at changing the config loading behaviour, and ended up changing quite a bit of the code. You can take a look and see if you like some of the ideas.
Would fix #11 and #30