Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixing - remove an unexpected filter. #4

Merged
merged 2 commits into from Apr 26, 2019
Merged

Conversation

jaric
Copy link
Contributor

@jaric jaric commented Apr 26, 2019

Due to Google has supported a lang code which is called "zh-TW" and we can't filter by strtolower.

Here is all supported lang code below by Google API.

{
 "data": {
  "languages": [
   {
    "language": "af"
   },
   {
    "language": "am"
   },
   {
    "language": "ar"
   },
   {
    "language": "az"
   },
   {
    "language": "be"
   },
   {
    "language": "bg"
   },
   {
    "language": "bn"
   },
   {
    "language": "bs"
   },
   {
    "language": "ca"
   },
   {
    "language": "ceb"
   },
   {
    "language": "co"
   },
   {
    "language": "cs"
   },
   {
    "language": "cy"
   },
   {
    "language": "da"
   },
   {
    "language": "de"
   },
   {
    "language": "el"
   },
   {
    "language": "en"
   },
   {
    "language": "eo"
   },
   {
    "language": "es"
   },
   {
    "language": "et"
   },
   {
    "language": "eu"
   },
   {
    "language": "fa"
   },
   {
    "language": "fi"
   },
   {
    "language": "fr"
   },
   {
    "language": "fy"
   },
   {
    "language": "ga"
   },
   {
    "language": "gd"
   },
   {
    "language": "gl"
   },
   {
    "language": "gu"
   },
   {
    "language": "ha"
   },
   {
    "language": "haw"
   },
   {
    "language": "hi"
   },
   {
    "language": "hmn"
   },
   {
    "language": "hr"
   },
   {
    "language": "ht"
   },
   {
    "language": "hu"
   },
   {
    "language": "hy"
   },
   {
    "language": "id"
   },
   {
    "language": "ig"
   },
   {
    "language": "is"
   },
   {
    "language": "it"
   },
   {
    "language": "iw"
   },
   {
    "language": "ja"
   },
   {
    "language": "jw"
   },
   {
    "language": "ka"
   },
   {
    "language": "kk"
   },
   {
    "language": "km"
   },
   {
    "language": "kn"
   },
   {
    "language": "ko"
   },
   {
    "language": "ku"
   },
   {
    "language": "ky"
   },
   {
    "language": "la"
   },
   {
    "language": "lb"
   },
   {
    "language": "lo"
   },
   {
    "language": "lt"
   },
   {
    "language": "lv"
   },
   {
    "language": "mg"
   },
   {
    "language": "mi"
   },
   {
    "language": "mk"
   },
   {
    "language": "ml"
   },
   {
    "language": "mn"
   },
   {
    "language": "mr"
   },
   {
    "language": "ms"
   },
   {
    "language": "mt"
   },
   {
    "language": "my"
   },
   {
    "language": "ne"
   },
   {
    "language": "nl"
   },
   {
    "language": "no"
   },
   {
    "language": "ny"
   },
   {
    "language": "pa"
   },
   {
    "language": "pl"
   },
   {
    "language": "ps"
   },
   {
    "language": "pt"
   },
   {
    "language": "ro"
   },
   {
    "language": "ru"
   },
   {
    "language": "sd"
   },
   {
    "language": "si"
   },
   {
    "language": "sk"
   },
   {
    "language": "sl"
   },
   {
    "language": "sm"
   },
   {
    "language": "sn"
   },
   {
    "language": "so"
   },
   {
    "language": "sq"
   },
   {
    "language": "sr"
   },
   {
    "language": "st"
   },
   {
    "language": "su"
   },
   {
    "language": "sv"
   },
   {
    "language": "sw"
   },
   {
    "language": "ta"
   },
   {
    "language": "te"
   },
   {
    "language": "tg"
   },
   {
    "language": "th"
   },
   {
    "language": "tl"
   },
   {
    "language": "tr"
   },
   {
    "language": "uk"
   },
   {
    "language": "ur"
   },
   {
    "language": "uz"
   },
   {
    "language": "vi"
   },
   {
    "language": "xh"
   },
   {
    "language": "yi"
   },
   {
    "language": "yo"
   },
   {
    "language": "zh"
   },
   {
    "language": "zh-TW"
   },
   {
    "language": "zu"
   }
  ]
 }
}

@introwit
Copy link
Member

Hi @jaric thank you for the PR 🙂 however, since it's just a single code that isn't lowercased, can you make the check skip strtolower only if the code is the zh-TW one?

@introwit
Copy link
Member

also can you add a test case for it? Thank you 🙂

@introwit introwit merged commit 63a2c17 into JoggApp:master Apr 26, 2019
@introwit
Copy link
Member

@jaric thank you for pointing it out Jaric, have tagged a new release 🙂Lemme know how it goes ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants