Feature/override format option #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 14, 2019 10:45
…into feature/override_format_option
|
@RossUK88 thank you for the contribution Ross ❤️ Can you please fix/add the necessary tests too? And also update the readme with the docs on what a 'format' actually is in the context of the package and what format options do what so that everyone can take advantage of your contribution 😄 |
Add additional test for taking a HTML parameter Update README for Format parameter and options allowed, with link to Translate API Docs
|
@introwit Should be all updated now. If you could have a quick check over that would be ace :) |
|
@RossUK88 thank you so much Ross 🙂Since you added default param values to prevent any breaking changes, I tagged a new patch release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the package to have formats passed as a 3rd parameter.
This allows users to now specify a HTML format and get more accurate results from translating strings of HTML.
No breaking changes as this still defaults to text if nothing is passed in.