Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Specialty to an attribute roll re-applies existing 'Add bonus' modifiers again #798

Closed
JohanFalt opened this issue Jan 26, 2024 · 1 comment
Labels
Bug Something isn't working
Milestone

Comments

@JohanFalt
Copy link
Owner

JohanFalt commented Jan 26, 2024

Replicate the bug by making a new merit in the Notes tab then use "Add Bonus" on the new merit to give a -2 difficulty modifier to any attribute(Perception in this case), then click the checkmark to apply the newly created merit to the sheet.

Go to the main sheet tab and click Perception. It will be at -2 difficulty because of our new merit. Click the specialty checkmark, Perception will now be at -4 difficulty modifier erroneously. Further checking/unchecking the specialty button keeps adding more -2 modifiers until it hits the cap.

This is an issue because you can't use merit 'Add Bonus' Attribute difficulty modifiers and apply Specialty to the roll at the same time in a proper way, since it will always apply the modifier twice if you check for Specialty.

For some reason the bug doesn't happen when used in a Skill+Attribute+Specialty pool, only when it's Attribute+Specialty alone

@JohanFalt JohanFalt added the Bug Something isn't working label Jan 26, 2024
@JohanFalt JohanFalt added this to the v4.0 milestone Jan 26, 2024
@JohanFalt JohanFalt reopened this Jan 26, 2024
@JohanFalt
Copy link
Owner Author

For some reason the bug doesn't happen when used in a Skill+Attribute+Specialty pool, only when it's Attribute+Specialty alone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant