Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated quotes #32

Closed
srosebattles opened this issue Sep 6, 2022 · 4 comments
Closed

Duplicated quotes #32

srosebattles opened this issue Sep 6, 2022 · 4 comments

Comments

@srosebattles
Copy link
Contributor

A number of quotes are the same, just cut slightly different with more or less text. Is this intended/desired?
e.g.
00:00|twelve|Bernardo: 'Tis now struck twelve; get thee to bed, Francisco.|Hamlet |Shakespeare|unknown
00:00|twelve|Francisco. You come most carefully upon your hour. Bernardo. 'Tis now struck twelve. Get thee to bed, Francisco.|Hamlet |William Shakespeare|unknown

@JohannesNE
Copy link
Owner

JohannesNE commented Sep 8, 2022

This is not intended.
In this case I prefer nr two, but with the punctuation from nr 1 🤷
I do not have a strong opinion on this though.

Thank you very much for your PR (#33)
I will look though it and generate the .json files ASAP.

@srosebattles
Copy link
Contributor Author

I think a lot of these duplicates were introduced with #29.
I'd be happy to go through and do some editing if you haven't already started doing that. I'll put it up as a separate PR, though.

@JohannesNE
Copy link
Owner

JohannesNE commented Sep 8, 2022 via email

@JohannesNE
Copy link
Owner

fixed in #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants