-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflows: Jobs shouldn't depend on each other #70
Comments
With 6980985 I introduced continue-on-error but the problem is that even though the windows job "crashes" at the create-environment step the environment still exists (probably corrupted) and therefore also the files can be exported. This should not happen as these files will lead to a corrupted environment. Try: |
Solved with 0701064. The only issue that we have now is that in the Workflows GUI failed steps look like they ran sucessfully (because of There's already a discussion on that: The current way to see if each runner ran sucessfully is therefore to manually inspect the createEnvironment step post-hoc |
Reopening this issue, because I don't like the fact that it can look like a worker succeeded, when it actually didn't. Try another approach, by simply tweaking the second job (downloading artifacts and pushing them). The logic here should be: "Run this job, if any previous ones (ubuntu-latest or windows-latest or both) succeeded" See this link: |
Uploading works now, but the ubuntu-latest and windows-latest jobs are still dependent on each other. We have to make sure that they run in parallel (to save time & because we don't want to write the code twice) and independently (don't skip one worker just because the other failed). Maybe this helps: https://github.com/orgs/community/discussions/27192#discussioncomment-3254966 |
Solved with last commit a4eb9c3 |
Currently we have the situation that the Ubuntu job runs through successfully but the Windows job crashes (because of matplotlib installation). Would be nice, if in this case the files from the sucessful worker would still be uploaded. The files of the crashed worker would then stay untouched (and therefore stay with last stable version).
The text was updated successfully, but these errors were encountered: