Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gap to support Gleam v0.33.0 #6

Merged
merged 2 commits into from
Jan 14, 2024
Merged

Conversation

dmmulroy
Copy link
Contributor

@dmmulroy dmmulroy commented Jan 8, 2024

I am working on updating the exercism test runner for the gleam track. This is listed as a dependency and needed to be upgraded to support the most recent version of Gleam.

It seems there were a few API changes - namely switching from map to dict and potentially also the argument order of index_map.

I also wasn't sure how to handle the exhaustive cases for proceed_path.

Happy to make any changes necessary!

@JohnBjrk
Copy link
Owner

Thank you for helping out with this 🙏

I think it makes sense to handle the missing cases with a runtime-error. The Myers algorithm implementation was adapted from a corresponding Elixir implementation and I'm also a bit sure if there is a way to handle this without runtime errors. I suspect this is a case that can never happen but with this change it is at least clear that this was the expectation.

There seem to be some formatting errors that show up in the test step. I'm a bit confused since it seems you have done some reformatting of the files (I assume with gleams formatter). Could you have a look at this? If you think the files are already correctly formatted please let me know and I can check if there is something strange going on in my GitHub action.

@hayleigh-dot-dev
Copy link

There seem to be some formatting errors that show up in the test step. I'm a bit confused since it seems you have done some reformatting of the files (I assume with gleams formatter).

The files not currently touched by this PR will still be formatted according to Gleam 0.31.0. I suggest @dmmulroy does a quick pass and runs the formatter on every file to get the CI passing :)

@JohnBjrk
Copy link
Owner

The files not currently touched by this PR will still be formatted according to Gleam 0.31.0. I suggest @dmmulroy does a quick pass and runs the formatter on every file to get the CI passing :)

Good catch @hayleigh-dot-dev 🙌 Apparently I didn't spend enough time looking at which files the formatter complained about 😂

@dmmulroy
Copy link
Contributor Author

Done! Thanks for the pointer :)

@JohnBjrk
Copy link
Owner

Thank you 🙏

@JohnBjrk JohnBjrk merged commit 903a415 into JohnBjrk:main Jan 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants