-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blurred video on new MacBook Pro 16" #942
Comments
same issue over here, I've downloaded all videos in 4K HDR so it isn't even streaming |
@Maffiow can you take a picture so I can get an idea of what's happening ? |
Thanks for this it certainly looks quite uncrisp ! Any chance you can give me a debug log ? Enable that in the Advanced tab, there might be something different with that screen that I'm not handling correctly for some reason. The log will give me more details about how the screen is detected, there might be a clue in there. This happen 100% of the time too, right ? Also, with Aerial, streaming will never look blurry, it may stall but never degrades quality, as their server isn't configured for that. So please when you have a chance, get me the log (enable in settings and launch the screensaver once, then attach the file here), hopefully I can fix this quickly ! |
6:17:36 PM : avInit .saver (0.0, 0.0, 296.0, 184.0) p: true o: true I just reinstalled it to make sure... same issue. And yes, 100% of the time. I noticed it the second I installed on new laptop and ever since. |
I see ! The log looks ok but it just contains the startup of the preference panel, not a run of the screensaver itself in full screen. Could you delete it, and launch the screensaver itself (not the preference panel), so I can see what is reported to us exactly ? From your log I can gather a bit of info and the screen detection looks ok. It's possible however that we are not getting the correct size from the screensaver API when it runs, so that would be helpful. Thanks again and sorry about the bug. |
6:48:12 PM : avInit .saver (0.0, 0.0, 296.0, 184.0) p: true o: true |
Sorry but I want to be 100% clear. Did you close System Preferences and launched the screensaver itself (in full screen mode ?). Maybe I wasn't clear so apologies if so, please try this:
Do not reopen system preferences before pasting the result. I'm still getting the tiny preview info from System Preferences in this log. Thanks again! |
Hi. I will try again. I will say, I waited for the screensaver to appear before I copied log. I did not click a hot-corner though. |
Sometimes the writes are delayed a bit in Catalina, so maybe wait 1 minute before reopening the log file, it may help ! And make sure System Preferences is closed. I'll have a look tomorrow as it's getting late here, I'll let you know what I can gather from that and hopefully I can fix that bug. Thanks ! |
10:07:24 PM : avInit .saver (0.0, 0.0, 296.0, 184.0) p: true o: true If this is not correct, please let me know. I am happy to try again. This time I waited before opening. |
That's all there was in the file, nothing before, nothing after ? I think there's something else amiss if so, I'm wondering, do you remember if you installed Aerial for all users, or just your user ? I'll think about it, I may have an idea about what's happening but it kinda looks like you don't get logs at all from the real screensaver, just the panel. Very weird. Someone else had issues with what looked like shortened logs too but eventually got it, I don't know if it's a delayed write thing, a text editor thing, or something else entirely. Edit: I double checked here, to see if installing for All users instead of individual users changed anything with regards to logging, but nope, trying another idea :) |
Thats all of it. I installed just for my user, however, I just deleted and reinstalled for all users. Same issue.
… On Mar 5, 2020, at 5:09 AM, Guillaume Louel ***@***.***> wrote:
That's all there was in the file, nothing before, nothing after ?
I think there's something else amiss if so, I'm wondering, do you remember if you installed Aerial for all users, or just your user ?
I'll think about it, I may have an idea about what's happening but it kinda looks like you don't get logs at all from the real screensaver, just the panel. Very weird.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#942?email_source=notifications&email_token=AOXHNDJ4Y3BTWXTMB656RWLRF6B5PA5CNFSM4LAXNVBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN4ZZ4Y#issuecomment-595172595>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOXHNDNIURIZ27BTYJETD63RF6B5PANCNFSM4LAXNVBA>.
|
Ok thanks for confirming. Something is weird with logs but don't waste time on trying again, I'll give you a new build soonish and a new way to generate logs. Stay tuned! |
Ok so here's a new build. It may fix the issue or not, I tried to force retina, in case it wasn't reported correctly by the system, that seems reasonable considering your screenshot, but it's really based on a guess more than anything 😅 Regarding the logs, if you don't mind, let's try this (a bit long, sorry):
I know it's a bit long but hopefully the extra steps should help find what's wrong with logs, and then hopefully with your bug ! |
On Mar 5, 2020, at 12:00 PM, Guillaume Louel ***@***.***> wrote:
Ok so here's a new build. It may fix the issue or not, I tried to force retina, in case it wasn't reported correctly by the system, that seems reasonable considering your screenshot, but it's really based on a guess more than anything 😅
Regarding the logs, if you don't mind, let's try this (a bit long, sorry):
Delete your current Aerial version
Close your System Preferences if it's open. When I say this, I mean fully, by pressing the red cross that I circled in purple here (Aerial will stay loaded in memory if you don't fully close it) :
<https://user-images.githubusercontent.com/37544189/76009592-bbea5200-5f11-11ea-87e0-cd06d632bc51.jpg>
Install the new version for your user (that's the best way in Catalina) here : https://github.com/glouel/Aerial/releases/download/v1.8.2test1/Aerial.saver.zip <https://github.com/glouel/Aerial/releases/download/v1.8.2test1/Aerial.saver.zip>
This will open your System Preferences.
On the screenshot above, activate the hot corner thing just for this time (circled in blue)
Press the Screen Saver settings button to get Aerial's Preferences Sheet. Go to Advanced tab, press "Show in Finder" to get a Finder window where the log is. Keep that one aside.
Close the Preference Sheet, and fully close System Preferences (see above)
Now, delete the AerialLog.txt file from the finder window, keep the window.
Launch the "fullscreen" screensaver using the Hot Corner you've set.
Let it run for a few seconds, and press a key to exit the screensaver. Do not open System Preferences again please !!
Now, in your Finder window, you should have a newly created AerialLog.txt file. If you don't, please tell me. You may need to wait 5 seconds max but it should pop right away.
Please attach the newly created log here (you can drag'n drop the file in the reply field in github)
I know it's a bit long but hopefully the extra steps should help find what's wrong with logs, and then hopefully with your bug !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#942?email_source=notifications&email_token=AOXHNDIXFSU3IYF4V3KXBKDRF7SDBA5CNFSM4LAXNVBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEN6IZ2Y#issuecomment-595365099>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOXHNDM2Z7EV4GOZJDB2NHTRF7SDBANCNFSM4LAXNVBA>.
2020-03-05 13:36:31.315 : avInit .saver (0.0, 0.0, 1792.0, 1120.0) p: true o: false
2020-03-05 13:36:31.317 : <AerialView: 0x7f96ed609700> AerialView setup init (V1.8.2test1) preview: false
2020-03-05 13:36:31.317 : Probing availability of an update
2020-03-05 13:36:31.317 : Checking for update (probe mode)
2020-03-05 13:36:31.319 : Time Management initialized
2020-03-05 13:36:31.319 : Display Detection initialized
2020-03-05 13:36:31.319 : ***Display Detection***
2020-03-05 13:36:31.319 : 1 display(s) detected
2020-03-05 13:36:31.320 : 1cm = 51.968504717496515 points
2020-03-05 13:36:31.320 : npass: dict [__C.NSDeviceDescriptionKey(_rawValue: NSDeviceBitsPerSample): 8, __C.NSDeviceDescriptionKey(_rawValue: NSDeviceSize): NSSize: {1792, 1120}, __C.NSDeviceDescriptionKey(_rawValue: NSDeviceColorSpaceName): NSCalibratedRGBColorSpace, __C.NSDeviceDescriptionKey(_rawValue: NSScreenNumber): 2077748985, __C.NSDeviceDescriptionKey(_rawValue: NSDeviceIsScreen): YES, __C.NSDeviceDescriptionKey(_rawValue: NSDeviceResolution): NSSize: {144, 144}]
2020-03-05 13:36:31.320 : bottomLeftFrame (0.0, 0.0, 1792.0, 1120.0)
2020-03-05 13:36:31.320 : src orig : (0.0, 0.0)
2020-03-05 13:36:31.321 : left 0.0 below 0.0
2020-03-05 13:36:31.321 : [id=2077748985, width=1792, height=1120, bottomLeftFrame=(0.0, 0.0, 1792.0, 1120.0), topRightCorner=(1792.0, 1120.0), isMain=true, backingScaleFactor=2.0]
2020-03-05 13:36:31.321 : (0.0, 0.0, 1792.0, 1120.0)
2020-03-05 13:36:31.321 : ***Display Detection Done***
2020-03-05 13:36:31.321 : Using : Optional([id=2077748985, width=1792, height=1120, bottomLeftFrame=(0.0, 0.0, 1792.0, 1120.0), topRightCorner=(1792.0, 1120.0), isMain=true, backingScaleFactor=2.0])
2020-03-05 13:36:31.322 : <AerialView: 0x7f96ed609700> setting up player layer with bounds/frame: (0.0, 0.0, 1792.0, 1120.0) / (0.0, 0.0, 1792.0, 1120.0)
2020-03-05 13:36:31.322 : allDisplays
2020-03-05 13:36:31.323 : Using dot workaround for video driver corruption
2020-03-05 13:36:31.323 : Manifest init
2020-03-05 13:36:31.323 : app support exists
2020-03-05 13:36:31.324 : No customvideos.json at : /Users/ncbetz/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver/Data/Library/Application Support/Aerial/customvideos.json
2020-03-05 13:36:31.324 : isManifestCached 10 true
2020-03-05 13:36:31.324 : isManifestCached 11 true
2020-03-05 13:36:31.324 : isManifestCached 12 true
2020-03-05 13:36:31.324 : isManifestCached 13 true
2020-03-05 13:36:31.325 : 2020-03-04
2020-03-05 13:36:31.325 : Interval : Optional(-135390.99479794502)
2020-03-05 13:36:31.325 : No need to check for new videos
2020-03-05 13:36:31.325 : Manifests files were not loaded in class
2020-03-05 13:36:31.325 : Files were not already loaded in memory
2020-03-05 13:36:31.326 : Manifests are cached on disk, loading
2020-03-05 13:36:31.326 : Poi Strings Provider initialized
2020-03-05 13:36:31.326 : Preferred languages : ["en-US"]
2020-03-05 13:36:31.326 : Best matched language : en
2020-03-05 13:36:31.326 : Defaulting to bundle
2020-03-05 13:36:31.327 : path : /Library/Screen Savers/Aerial.saver/Contents/Resources/en.json
2020-03-05 13:36:31.327 : Community JSON : 99 entries
2020-03-05 13:36:31.327 : Using existing user cache ~/Library/Caches/Aerial
2020-03-05 13:36:31.327 : cache to be used : Optional("/Users/ncbetz/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver/Data/Library/Caches/Aerial")
2020-03-05 13:36:31.328 : Total videos processed : 99 callbacks : 0
2020-03-05 13:36:31.328 : <AerialView: 0x7f96ed609700> Setting player for all player layers in []
2020-03-05 13:36:31.328 : playlist only has one element, looping!
2020-03-05 13:36:31.328 : initvideocache
2020-03-05 13:36:31.328 : cached video file with length: 214199407
2020-03-05 13:36:31.329 : <AerialView: 0x7f96ed609700> playing video (OFFLINE MODE) : file:///Users/ncbetz/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver/Data/Library/Application%20Support/Aerial/comp_CH_C002_C005_PSNK_v05_SDR_PS_FINAL_20180709_SDR_4K_HEVC.mov
2020-03-05 13:36:31.329 : <AerialView: 0x7f96ed609700> observing current item <AVPlayerItem: 0x6000021fc7e0, asset = <AVURLAsset: 0x600002387620, URL = file:///Users/ncbetz/Library/Containers/com.apple.ScreenSaver.Engine.legacyScreenSaver/Data/Library/Application%20Support/Aerial/comp_CH_C002_C005_PSNK_v05_SDR_PS_FINAL_20180709_SDR_4K_HEVC.mov>>
2020-03-05 13:36:31.329 : <AerialView: 0x7f96ed609700> observeValue Optional("readyForDisplay") false (0.0, 0.0, 1792.0, 1120.0)
2020-03-05 13:36:31.329 : AssetLoaderDelegate deinit
2020-03-05 13:36:31.329 : <AerialView: 0x7f96ed609700> backing change 2.0 isDisabled: false frame: (0.0, 0.0, 1792.0, 1120.0) preview: false
2020-03-05 13:36:31.443 : //////// No update is available !
2020-03-05 13:36:31.491 : <AerialView: 0x7f96ed609700> observeValue Optional("readyForDisplay") true (0.0, 0.0, 1792.0, 1120.0)
2020-03-05 13:36:31.492 : start playback: (0.0, 0.0, 1792.0, 1120.0) (0.0, 0.0, 1792.0, 1120.0)
2020-03-05 13:36:31.841 : <AerialView: 0x7f96ed609700> startAnimation frame (0.0, 0.0, 1792.0, 1120.0) bounds (0.0, 0.0, 1792.0, 1120.0)
|
So first thanks for taking the time to make the log, this time it's ok and I have the info I needed, that's the good news! The bad news that I kind of expected is that my fix didn't work. According to the log it didn't even trigger, because the retina scaling was reported correctly by the OS. More worrisome to me is that everything looks "ok" according to the log. There's a lot of bug in Catalina with the screen saver sandbox but according to your log, you didn't hit those bugs. The view size is correct, and so is the retina factor. So at that point, I'm a bit puzzled. I'll try to think of something and get back to you, sorry ! |
This comment has been minimized.
This comment has been minimized.
Hi
Could you try going all the way to the left just to test, and launch the screensaver ? Is it still blurry ? Ok that's about it for this time, no hurry with those but hopefully it will help narrow things down a bit ! Thanks ! |
Hi,
- Yes, video is blurry and almost foggy in a way. The clock is very crisp.
- This occurs when on and off battery.
- I tried changing scaling and issue occurred on every scale level.
I believe the downloaded videos look fine? I am not sure. I could always send one.
Hope this helps. I am happy to continue help you troubleshoot.
… On Mar 6, 2020, at 7:25 AM, Guillaume Louel ***@***.***> wrote:
Hi @noahcbetz <https://github.com/noahcbetz> !
I've been thinking a bit and have a few questions/things for you to try if that's ok :
I think you said so but I want to be 100% clear, only the video is blurry, right ? The text (clock etc) appears crips correct ?
You are seeing this both on battery and when charging ?
In Aerial's Preference Sheet, control-click a video you have cached and select "Open in Quicktime". This should open Quicktime (if it opens something else, please open quicktime manually and open the video there). Press cmd+ctrl+F to go fullscreen and start playback. Is it blurry ?
If you go to System Preferences > Monitor, you'll see something like this :
<https://user-images.githubusercontent.com/37544189/76086900-5cde1900-5fb5-11ea-86a5-62c635570794.png>
Could you try going all the way to the left just to test, and launch the screensaver ? Is it still blurry ?
What if you go all the way to the right ? (I'm wondering if it's not a scaling bug with macOS)
Ok that's about it for this time, no hurry with those but hopefully it will help narrow things down a bit ! Thanks !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#942?email_source=notifications&email_token=AOXHNDIHBKGX4TFS62CBXG3RGD2URA5CNFSM4LAXNVBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOBKYIA#issuecomment-595766304>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOXHNDJB3EGWMR5STT7XAJDRGD2URANCNFSM4LAXNVBA>.
|
My question was, do they play ok (non blurry) in quicktime in fullscreen ? I see no reason that you'd have corrupted files, your cache size is correct so they are not truncated or anything.
Thanks for the rest of your feedback, it's helpful ! I'm still thinking about it and will let you know if I find anything. I'll make another test build and let you know. |
Hi again Noah If this is not too much trouble, I'd like it if you could try running the .app version of Aerial. Basically, it's the same thing as Aerial, except it runs as an app instead of a screensaver. This is what I use to debug/develop Aerial. I made a build available here : https://github.com/glouel/Aerial/releases/download/v1.8.2test2/AerialApp.app.zip Inside the .zip, you'll find AerialApp.app, just double click it. I didn't notarize it so you'll get a warning that it's from an unidentified developper the first time you try and run it. After that, ctrl click the .app (or right click) and select open, it will warn you again but will let you open the app. Basically it looks like this, you have a window that shows what you see in System Preferences, and another that shows the screensaver view in a window : It won't load your settings nor your cache, so it should start to stream a file. You can either change settings/download a video if you want (you need to close/reopen the app for the changes to get reloaded). My question is, is the video playing in a blurry way in the window ? If you are in doubt, you can quickly make a screenshot of your whole screen using IF it's not blurry, can you press the green button on the top left of the preview, to put the video in fullscreen ? When there, does it get blurry ? If it's not blurry, please press the right arrow key, it will load a new video. Is it still not blurry ? If it's blurry see instructions above to make a screenshot (it will appear on your desktop). Thanks a lot and let me know if you need help running the app. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi Noah ! I didn’t get your screenshot, you may need to post it via GitHub and not by email. Thanks for checking and reporting back ! |
Hi, Here are two screenshots of a video in quicktime and in the screensaver: I can't see any differences here, but when I compare the video with a 4k HEVC video on youtube the local video is not really nice to watch... for example: https://www.youtube.com/watch?v=FSsKheh4IW8 |
Hi @rbeier ! Thanks I appreciate it ! Could I ask you to attach the screenshots directly to github (just drag'n drop the png) so I can get a better feel ? Imgur is excruciatingly slow here and they recompress everything. It's one time where it would really help to see the png. According to you you get abotu the same results in quicktime & aerial, which is what you should get. I'll check your screenshots in an hour and get back to you, this could be a macOS bug then, possibly with the video decoding on that machine. |
the images are > 10MB and github don't let me upload it directly. Maybe i can send you an email or upload the screenshots to dropbox / google drive? |
Please email them yep ! Many thanks ! (I managed to open the imgur ones, the text is blurry too from the jpeg but it's definitely bad and similar on both, I'll try to show you how it should look like at your screensize in a min) |
Got them, thanks a lot ! After spending some time comparing here with what I get, this is about the same, here I took a couple of screenshots with your exact screen resolution. 4K HEVC : The 4K HDR is a tiny bit sharper but not by much. To my eye, 4K HEVC is about what you have in your screenshot which is the real quality of the video. I think that in your case, this is just how the videos are and probably not the issue that others have reported. Some of the videos, including this one, are definitely not sharp. Some are a bit old, the "aerial" ones were not originally available in 4K, and some are pretty soft. That's just the way they are. |
Closing this, feel free to reopen/open a new one if someone experiences such an issue and wants to investigate further. |
I am running a MacBook Pro 16" on the latest version of Arial and MacOS.
On every since screen resolution, my Arial screensaver is blurry.
The text was updated successfully, but these errors were encountered: