Merge 5a44c97 into af83347

JohnCoene · Nov 23, 2020 · 50a4e7d · 50a4e7d
2 parents af83347 + 5a44c97
commit 50a4e7d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,7 @@
 - Fixed `e_parallel` arguments, see [#223](https://github.com/JohnCoene/echarts4r/issues/223)
 - Accept `data.tree` data for easy creation of tree, treemaps and sunbursts, see [#207](https://github.com/JohnCoene/echarts4r/issues/207)
 - Fix ordering in timeline [#234](https://github.com/JohnCoene/echarts4r/issues/234)
+- Fix the issue that `e_band()` displays the upper band incorrectly, see [#237](https://github.com/JohnCoene/echarts4r/issues/237). Thanks @shrektan for the reporting and PR.
 
 # echarts4r 0.3.3
 

diff --git a/R/add_.R b/R/add_.R
@@ -2113,7 +2113,7 @@ e_band_ <- function(e, min, max, stack = "confidence-band", symbol = c("none", "
     e <- do.call(e_line_, min_opts_index)
 
     # max
-    # e$x$data[[i]][, max] <- e$x$data[[i]][[serie]] - e$x$data[[i]][[max]]
+    e$x$data[[i]][, max] <- e$x$data[[i]][, max] - e$x$data[[i]][, min]
     max_opts_index <- max_opts
     max_opts_index$e <- e
     max_opts_index$stack <- stack