Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect display of confidence bands #332

Open
Alik-V opened this issue Jun 23, 2021 · 3 comments
Open

Incorrect display of confidence bands #332

Alik-V opened this issue Jun 23, 2021 · 3 comments

Comments

@Alik-V
Copy link

Alik-V commented Jun 23, 2021

Hi John,
Thanks a lot for this package, it's been a tremendous pleasure using it so far.

I am having a problem creating confidence intervals using e_bands function.
It seems that upper band is always overstating itself. If we follow the example in documentation with an addition of tooltips:

set.seed(5)
df <- data.frame(
  x = 1:10,
  y = runif(10, 5, 10)
) %>%
  dplyr::mutate(
    lwr = y - runif(10, 1, 3),
    upr = y + runif(10, 2, 4)
  )
df %>%
  e_charts(x) %>%
  e_line(y) %>%
  e_band(lwr, upr) %>%
  e_tooltip(trigger = "axis", formatter = e_tooltip_pointer_formatter(digits = 2))

image

The upper bound is stated as 9.78 whereas it shoots to ~14 on the plot.

@swsoyee
Copy link
Contributor

swsoyee commented Jun 23, 2021

The problem has been fixed in #238
Maybe you need to update the package version to the latest.

@Alik-V
Copy link
Author

Alik-V commented Jul 2, 2021

Thank you @swsoyee! Updating to 0.4.0 did indeed fix the issue of incorrect band display. However, there might be another potential bug with the tooltips. Running the code above results in the following dataset and plot:
image
image

While the bands themselves are correctly plotted, the tooltip is displaying a wrong number, which is essentially upr - lwr in this example

@svenb78
Copy link

svenb78 commented Dec 28, 2021

Hi,

I have the same problem. Is there any solution so far?

Best, Sven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants