Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e_band() now displays correct upper lines #238

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

shrektan
Copy link
Contributor

Closes #237

Code

library(echarts4r)
df <- data.frame(
  x = 1:10,
  y = runif(10, 5, 10)
) %>%
  dplyr::mutate(
    lwr = y - 2,
    upr = y + 2
  )

df %>%
  e_charts(x) %>%
  e_line(y) %>%
  e_band(lwr, upr)

Before the PR

image

After the PR

image

@JohnCoene
Copy link
Owner

Looks good, thank you. Can you add yourself as ctb to the DESCRIPTION (if you want to)?

@shrektan
Copy link
Contributor Author

Sure, added 😃

@JohnCoene JohnCoene merged commit c30c8b5 into JohnCoene:master Nov 23, 2020
@JohnCoene
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e_band()'s upper line is incorrect
2 participants