Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'length(x) = 2 > 1' in coercion to 'logical(1)' - R version 4.3.0 #520

Open
william-lima-p opened this issue May 4, 2023 · 6 comments
Open

Comments

@william-lima-p
Copy link

As per https://cran.r-project.org/doc/manuals/r-devel/NEWS.html, using || in if statements is no longer safe in R 4.3.0.

For that reason, something like tibble(Column = rep(as.POSIXct('2023-01-01'), 3)) %>% e_chart(Column) will throw out an error.

JohnCoene added a commit that referenced this issue May 4, 2023
@JohnCoene
Copy link
Owner

Thanks for flagging this. This should be fixed.

@william-lima-p
Copy link
Author

Thanks!

@william-lima-p
Copy link
Author

Still happpens when using timeline, unfortunately. For example:

tibble(
  Column = rep(as.POSIXct('2023-01-01'), 3),
  Letter = LETTERS[1:3]
) %>%
  group_by(Letter) %>%
  e_chart(Column, timeline = TRUE)

@william-lima-p william-lima-p reopened this May 4, 2023
JohnCoene added a commit that referenced this issue May 5, 2023
@JohnCoene
Copy link
Owner

Sorry. Should be good now.

@william-lima-p
Copy link
Author

Perfect! Thank you.

@william-lima-p
Copy link
Author

John, it still happens with e_charts_, for me. Example:

tibble(
  Column = rep(as.POSIXct('2023-01-01'), 3),
  Letter = LETTERS[1:3]
) %>%
  group_by(Letter) %>%
  e_charts_('Column', timeline = TRUE)

This throws out

Error in cl == "character" || cl == "factor" : 
  'length = 2' in coercion to 'logical(1)'

With e_charts, it's all fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants