Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #204 Fix quotation in LICENSE.md and Bug in the #199 #205

Merged
merged 3 commits into from Oct 7, 2020

Conversation

swsoyee
Copy link
Contributor

@swsoyee swsoyee commented Oct 7, 2020

I'm so sorry about submit two unrelated commits in one PR (forgetting to switch the branch)

In 1a9d63f , Just update the quotation in license file.
Ref: http://www.apache.org/licenses/LICENSE-2.0


In d289a0b , Fix the problem cause be evalFun()

When I using the dev version to reproduce the demo in #153, the bar seems to be drawn from the index 1.

df <- data.frame(
  x = factor(c(1, 2)),
  y = c(1, 5),
  upper = c(1.1, 5.3),
  lower = c(0.8, 4.6)
)

df %>%
  e_charts(x) %>%
  e_bar(y)

image

I have check the options before and after evalFun() conversion, it seems the results are identical. I can not figure out where is the problem but after d289a0b the bug have been solved.

image

@swsoyee swsoyee changed the title fix: #204 Fix quotation in LICENSE.md fix: #204 Fix quotation in LICENSE.md and Bug cause in the #199 Oct 7, 2020
@swsoyee swsoyee changed the title fix: #204 Fix quotation in LICENSE.md and Bug cause in the #199 fix: #204 Fix quotation in LICENSE.md and Bug in the #199 Oct 7, 2020
@JohnCoene JohnCoene merged commit 4e4c7ee into JohnCoene:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants