Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: close #210 use styler::style_pkg() #211

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

swsoyee
Copy link
Contributor

@swsoyee swsoyee commented Oct 8, 2020

Also considering use pre-commit.hooks and {lintr} to set some limitation to code style and auto formatting in later PR, at the same time do not put too much of burdens on other contributors.

Not going to use {lintr} recently, since it will affect too many code.

> styler::style_pkg()
Styling  33  files:
 R/actions.R       ℹ 
 R/add_.R          ℹ 
 R/add.R           ℹ 
 R/append.R        ℹ 
 R/boxes.R         ℹ 
 R/button.R        ℹ 
 R/calendar.R      ℹ 
 R/callbacks.R     ℹ 
 R/color.R         ℹ 
 R/echarts4r.R     ℹ 
 R/facets.R        ℹ 
 R/general.R       ℹ 
 R/geo.R           ℹ 
 R/globe.R         ℹ 
 R/graphic.R       ℹ 
 R/grid.R          ℹ 
 R/grid3d.R        ℹ 
 R/group2series.R  ℹ 
 R/helpers.R       ℹ 
 R/leaflet.R       ℹ 
 R/loading.R       ℹ 
 R/map.R           ℹ 
 R/mark.R          ℹ 
 R/nesting.R       ℹ 
 R/opts.R          ℹ 
 R/plugins.R       ℹ 
 R/proxies.R       ℹ 
 R/themes.R        ℹ 
 R/timeline.R      ℹ 
 R/utils-exports.R ✓ 
 R/utils-pipe.R    ✓ 
 R/utils.R         ℹ 
 R/zzz.R           ℹ 
────────────────────
Status	Count	Legend 
✓ 	2	File unchanged.
ℹ 	31	File changed.
x 	0	Styling threw an error.
────────────────────
Please review the changes carefully!

After this commit, it may need also need to update the Rd and pkgdown site because those examples before functions are been styled as well. I can do the update If needed, too. But I think it will be better to confirmed the first commit at first.

devtools::document()
pkgdown::build_site()

@JohnCoene JohnCoene merged commit e60d59f into JohnCoene:master Oct 14, 2020
@swsoyee swsoyee deleted the use-styler branch October 14, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants