Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #79 e_tooltip_item_formatter work with e_flip_coords #215

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

swsoyee
Copy link
Contributor

@swsoyee swsoyee commented Oct 20, 2020

  • Use the method provided by @artemklevtsov to fix the problem.
  • Because {echarts4r} is not using the dataset property, so it may need to do lots of refactoring for using the dataset[i].source way to flip coordinates.

Source: #79 (comment)

Co-Authored-By: Artem Klevtsov 603798+artemklevtsov@users.noreply.github.com

- Use the method provided by @artemklevtsov to fix the problem.
- Because {echarts4r} is not using the `dataset` property, so it may need to do lots of refactoring for using the `dataset[i].source` way to flip coordinates.

Co-Authored-By: Artem Klevtsov <603798+artemklevtsov@users.noreply.github.com>
@JohnCoene JohnCoene merged commit b22bc25 into JohnCoene:master Oct 20, 2020
@JohnCoene
Copy link
Owner

Ah, nicely done: I had not thought of that!

@swsoyee swsoyee deleted the fix-issue-79 branch October 20, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants