e_band2 and updates to e_error_bar #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e_error_bar is now more robust and customizable, renderErrorBar2 in renderers.js was also heavily rewritten. e_band2 is a new chart for "area bands". Very similar to the original e_band, but with a different visualization method. The main goal was to handle better e_y_axis(scale=TRUE) and see the bands with maximal auto-zoom. Sorry, ran build_reference() by mistake and updated 100 files unnecessarily.
|
It is better to include e_scatter as a chart e_error_bar can attach to. # add_.R after line 2237
if (info==0) info <- length(unlist(lapply(ser, function(x) grep('line', x))))
if (info==0) info <- length(unlist(lapply(ser, function(x) grep('scatter', x)))) # new line to support e_scatter |
|
Looks good, thank you. I'll review that today. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e_error_bar is now more robust and customizable, renderErrorBar2 in renderers.js was also heavily rewritten.
e_band2 is a new chart for "area bands". Very similar to the original e_band, but with a different visualization method. The main goal was to handle better e_y_axis(scale=TRUE) and see the bands with maximal auto-zoom. Could address issue #113 as well.
Sorry, ran build_reference() by mistake and updated 100 files unnecessarily.