New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use seq_along() instead of 1:length() #236

Merged

JohnCoene merged 1 commit into JohnCoene:master from shrektan:seq_along

Nov 23, 2020

Contributor

shrektan commented Nov 23, 2020

I think seq_along() is better than 1:length() as the latter will cause unexpected results when x is length zero. In addition, it's faster.

x <- character()
1:length(x)
#> [1] 1 0
seq_along(x)
#> integer(0)

^{Created on 2020-11-23 by the reprex package (v0.3.0)}


          use seq_along() instead of 1:length

526d0e9

Owner

JohnCoene commented Nov 23, 2020

Indeed, I always overlook this.

JohnCoene merged commit 9f22f61 into JohnCoene:master

shrektan deleted the seq_along branch

November 23, 2020 16:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment