Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e_legend such that icon argument can be used. #499

Merged
merged 2 commits into from
Jan 13, 2023

Conversation

yogat3ch
Copy link
Contributor

R's partial matching of arguments made it such that a single value passed as argument icon to e_legend when multiple legend$data objects are present in the chart causes this error:

Error in echarts4r::e_legend(e, icon = "circle") : 
  invalid number of icons; 1 icons passed but 4 legend items.

This modifies e_legend to allow for the expected behavior which uses it as the icon argument in opts$legend effectively changing the icon for the entire legend.

@JohnCoene JohnCoene merged commit bf23891 into JohnCoene:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants