Robuster Erroring #123
Merged
Robuster Erroring #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnDTill
commented
Aug 3, 2023
JohnDTill
commented
Aug 3, 2023
There was a problem hiding this comment.
This is the right direction. However, requiring guards on Selection logic and having wonky Selections in the presence of Errors is too high a price for the universal PARSE_ERROR node. This should be updated so that Error nodes are dynamic, and include a Selection.
Also rename and enforce check for accessing while potentially growing array
|
I shouldn't have applied formatting updates on this MR, but what the heck- it's amatuer hour. |
JohnDTill
commented
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make access operations on Error nodes generally valid, so that there is a limited amount of operations requiring guards