[actor shutdown] Add a context macro to thread_executor #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a new
context!macro in thread_executor that just makes constructing context objects less visually intrusive (8 lines per instantiation!). Code is much easier to read now.Motivation
Part of #29.
The changes for actor shutdown will introduce more instances in which a context object will be created from a system context. It made sense to invest in a macro here to save some typing. Took a few iterations to get this working right (so many TIL moments).
Test Plan
If it compiles it's good. This change should be functionally equivalent to what existed before.