Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Propegates shutdown signals to children via the runtime manager. Currently there is no coordination between timing/ordering of parents and children except for the flow of initial messages. That is to say that the actual moment in which actors are removed from the runtime queue and the
before
/after_stop
methods are finished may race. I think this is a fine trade-off for now. Coordination is a lot trickier, and possibly not necessary.Motivation
Part of #29.
Actors are organized in heirarchical trees. In an actor system, all actors should be part of the same tree and thus if an actor shuts down and has children, the shutdown signals have to propegate down the tree.
Test Plan
TBD. Will address testing as the final step in impelemnting actor shutdown.