Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actor shutdown] shutdown children #75

Merged
merged 1 commit into from
Jul 2, 2023
Merged

Conversation

JohnMurray
Copy link
Owner

Summary

Propegates shutdown signals to children via the runtime manager. Currently there is no coordination between timing/ordering of parents and children except for the flow of initial messages. That is to say that the actual moment in which actors are removed from the runtime queue and the before/after_stop methods are finished may race. I think this is a fine trade-off for now. Coordination is a lot trickier, and possibly not necessary.

Motivation

Part of #29.

Actors are organized in heirarchical trees. In an actor system, all actors should be part of the same tree and thus if an actor shuts down and has children, the shutdown signals have to propegate down the tree.

Test Plan

TBD. Will address testing as the final step in impelemnting actor shutdown.

@JohnMurray JohnMurray merged commit 7372322 into main Jul 2, 2023
4 checks passed
@JohnMurray JohnMurray deleted the shutdown/child-shutdown branch July 2, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant