Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actor shutdown] cell state bitmask fix #76

Merged
merged 2 commits into from
Jul 22, 2023
Merged

Conversation

JohnMurray
Copy link
Owner

Summary

When an actor shuts down, the state bitmask in the ActorCell is flipped from the Context object when a shutdown is requested. Previously this was only set within the executor.

Motivation

Part of #29

There is an asynchronous delay between an actor signaling it is shutting down to when the executor sets the state. This is because the request travels through the runtime manager and then back to the executor via async channel communications.

What is described above introduces a window where an actor has signaled shutdown and continues to receive messages. By setting the shutdown flag directly within the actor (as well as within the executor), messages processing by the actor will stop immediately.

Test Plan

Shutdown testing will be covered in the broader actor shutdown effort.

@JohnMurray JohnMurray added this to the 0.3.0 milestone Jul 22, 2023
@JohnMurray JohnMurray self-assigned this Jul 22, 2023
@JohnMurray JohnMurray merged commit b979f87 into main Jul 22, 2023
4 checks passed
@JohnMurray JohnMurray deleted the shutdown/bitmask-fix branch July 22, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant