Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/docs for summarization #448

Merged
merged 8 commits into from
May 23, 2023
Merged

Update/docs for summarization #448

merged 8 commits into from
May 23, 2023

Conversation

Prikshit7766
Copy link
Contributor

Checklist:

  • updated documentation for the summarization

@Prikshit7766 Prikshit7766 linked an issue May 23, 2023 that may be closed by this pull request
Update docs for summarization on website #443
Closed
ArshaanNazir
ArshaanNazir reviewed May 23, 2023
View reviewed changes
Copy link
Collaborator

@ArshaanNazir ArshaanNazir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update requirements file

@Prikshit7766
Copy link
Contributor Author

are you reffering to Gemfile.lock

@Prikshit7766 Prikshit7766 reopened this May 23, 2023
ArshaanNazir
ArshaanNazir reviewed May 23, 2023
View reviewed changes
Copy link
Collaborator

@ArshaanNazir ArshaanNazir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also remove question-answering from supported tasks in label representation task ( both proportion and count one) and for bias tests add QA and summarization in supported tasks @Prikshit7766

@Prikshit7766
Copy link
Contributor Author

@ArshaanNazir
should i only remove question-answering from supported tasks in label representation task or summarization too

@ArshaanNazir
Copy link
Collaborator

ArshaanNazir commented May 23, 2023 •
edited
Loading

should i only remove question-answering from supported tasks in label representation task or summarization too

Remove it from label representation supported tests only. And for bias tests, add both question-answering and summarization to supported tests

@Prikshit7766
Copy link
Contributor Author

If there are any changes required, please let me know.

@ArshaanNazir
Copy link
Collaborator

ArshaanNazir commented May 23, 2023 •
edited
Loading

If there are any changes required, please let me know.

from label representation, remove summarization as well. And add QA and summarization to fairness tests as well @Prikshit7766

@ArshaanNazir ArshaanNazir merged commit 2945d2d into release/1.3.0 May 23, 2023
4 checks passed
@ArshaanNazir ArshaanNazir deleted the Update/docs-for-summarization branch May 26, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArshaanNazir ArshaanNazir ArshaanNazir left review comments

Assignees

@Prikshit7766 Prikshit7766

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update docs for summarization on website
2 participants
@Prikshit7766 @ArshaanNazir