Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: installation modes #597

Merged
merged 3 commits into from
Jul 7, 2023
Merged

feature: installation modes #597

merged 3 commits into from
Jul 7, 2023

Conversation

JulesBelveze
Copy link
Contributor

This PR aims at enabling the user to only install the backend libraries needed.

Example: pip install langtest[transformers]

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@JulesBelveze JulesBelveze marked this pull request as draft July 6, 2023 15:17
@JulesBelveze JulesBelveze changed the base branch from main to release/1.1.0 July 6, 2023 15:17
@JulesBelveze JulesBelveze self-assigned this Jul 6, 2023
This was linked to issues Jul 6, 2023
Get rid of transformers dependency #282
Closed
Get rid of evaluate dependency #558
Closed
@JulesBelveze JulesBelveze marked this pull request as ready for review July 7, 2023 06:49
@JulesBelveze JulesBelveze added the 🛠️ Maintenance Flagged under maintenance label Jul 7, 2023
@JulesBelveze JulesBelveze linked an issue Jul 7, 2023 that may be closed by this pull request
Remove unnecessary dependencies #540
Closed
chakravarthik27
chakravarthik27 approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@chakravarthik27 chakravarthik27 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's beneficial to include a feature for installing additional packages, such as pip install langtest[transformers].

@ArshaanNazir ArshaanNazir merged commit 1f28c98 into release/1.1.0 Jul 7, 2023
3 checks passed
@JulesBelveze JulesBelveze deleted the feature/installation-modes branch July 7, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chakravarthik27 chakravarthik27 chakravarthik27 approved these changes

@ArshaanNazir ArshaanNazir ArshaanNazir approved these changes

Assignees

@JulesBelveze JulesBelveze

Labels
🛠️ Maintenance Flagged under maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of evaluate dependency Remove unnecessary dependencies Get rid of transformers dependency
3 participants
@JulesBelveze @chakravarthik27 @ArshaanNazir