Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: model hub handler #601

Merged
merged 5 commits into from
Jul 10, 2023
Merged

fix: model hub handler #601

merged 5 commits into from
Jul 10, 2023

Conversation

JulesBelveze
Copy link
Contributor

@JulesBelveze JulesBelveze commented Jul 9, 2023 •
edited
Loading

This PR aims at fixing some loading mechanisms from the ModelHandler

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

RakshitKhajuria
RakshitKhajuria approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@RakshitKhajuria RakshitKhajuria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JulesBelveze JulesBelveze merged commit 3804809 into release/1.1.0 Jul 10, 2023
3 checks passed
@JulesBelveze JulesBelveze deleted the fix/model-hub-handler branch July 10, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RakshitKhajuria RakshitKhajuria RakshitKhajuria approved these changes

@chakravarthik27 chakravarthik27 Awaiting requested review from chakravarthik27

@ArshaanNazir ArshaanNazir Awaiting requested review from ArshaanNazir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JulesBelveze @RakshitKhajuria