Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/change runtime speed into a test #605

Merged
merged 31 commits into from
Jul 31, 2023
Merged

Refactor/change runtime speed into a test #605

merged 31 commits into from
Jul 31, 2023

Conversation

chakravarthik27
Copy link
Collaborator

@chakravarthik27 chakravarthik27 commented Jul 10, 2023 •
edited
Loading

This PR aims to provide a capability for testing responses to models in terms of tokens per second. The performance category includes the speed test type. In the future, any test type, such as memory tests,..., may be implemented under performance categories.

# Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@chakravarthik27 chakravarthik27 self-assigned this Jul 10, 2023
@chakravarthik27 chakravarthik27 linked an issue Jul 10, 2023 that may be closed by this pull request
Change runtime speed into a test #538
Closed
@ArshaanNazir ArshaanNazir changed the base branch from main to release/1.1.0 July 10, 2023 12:58
@ArshaanNazir ArshaanNazir linked an issue Jul 10, 2023 that may be closed by this pull request
Maybe rename runtime to speed #539
Closed
@ArshaanNazir ArshaanNazir self-assigned this Jul 10, 2023
@ArshaanNazir ArshaanNazir added the v2.1.0 Issue or request to be done in v2.1.0 release label Jul 10, 2023
@chakravarthik27 chakravarthik27 changed the base branch from release/1.1.0 to release/1.2.0 July 27, 2023 06:43
JulesBelveze
JulesBelveze reviewed Jul 28, 2023
View reviewed changes
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤓
Do you mind adding a few unittests please?
Also, could you add a few lines to describe the goal of this PR?

JulesBelveze
JulesBelveze approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just add a short description and feel free to merge 😄

@chakravarthik27
Copy link
Collaborator Author

Please just add a short description and feel free to merge 😄

I updated the description of the PR

@ArshaanNazir ArshaanNazir merged commit bd45e29 into release/1.2.0 Jul 31, 2023
3 checks passed
@ArshaanNazir ArshaanNazir deleted the refactor/change-runtime-speed-into-a-test branch August 7, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesBelveze JulesBelveze JulesBelveze approved these changes

@ArshaanNazir ArshaanNazir Awaiting requested review from ArshaanNazir

Assignees

@chakravarthik27 chakravarthik27

@ArshaanNazir ArshaanNazir

Labels
v2.1.0 Issue or request to be done in v2.1.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maybe rename runtime to speed Change runtime speed into a test
4 participants
@chakravarthik27 @JulesBelveze @ArshaanNazir @RakshitKhajuria