Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/ Robustness Tests -> Adjective synonym/antonym Swap #611

Merged
merged 16 commits into from
Jul 14, 2023
Merged

feature/ Robustness Tests -> Adjective synonym/antonym Swap #611

merged 16 commits into from
Jul 14, 2023

Conversation

RakshitKhajuria
Copy link
Contributor

@RakshitKhajuria RakshitKhajuria commented Jul 11, 2023 •
edited
Loading

This PR aims at adding new robustness tests ⭐

Checklist:

  • Adjective Synonym swap

    • Adjective Synonym swap : Data Dictionary scrapped from this website -> https://www.thesaurus.com/

  • Adjective Antonym swap

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@RakshitKhajuria RakshitKhajuria added ⭐ Feature Indicates new feature requests v2.1.0 Issue or request to be done in v2.1.0 release labels Jul 11, 2023
@RakshitKhajuria RakshitKhajuria marked this pull request as draft July 11, 2023 17:25
@RakshitKhajuria RakshitKhajuria linked an issue Jul 12, 2023 that may be closed by this pull request
Add more robustness tests (adjectives, age) #531
Closed
JulesBelveze
JulesBelveze reviewed Jul 13, 2023
View reviewed changes
langtest/transform/robustness.py Outdated Show resolved Hide resolved
langtest/transform/robustness.py Show resolved Hide resolved
@JulesBelveze
Copy link
Contributor

@RakshitKhajuria let's split this PR into two: one for "adjective swap" and one for "age" and let's merge this one. What do you think?

@RakshitKhajuria
Copy link
Contributor Author

@RakshitKhajuria let's split this PR into two: one for "adjective swap" and one for "age" and let's merge this one. What do you think?

Sure, that will be fine !

@RakshitKhajuria RakshitKhajuria changed the title feature/ Robustness Tests -> AdjectiveSwap and Age feature/ Robustness Tests -> AdjectiveSwap Jul 14, 2023
@RakshitKhajuria RakshitKhajuria marked this pull request as ready for review July 14, 2023 07:43
@RakshitKhajuria RakshitKhajuria changed the title feature/ Robustness Tests -> AdjectiveSwap feature/ Robustness Tests -> Adjective synonym/antonym Swap Jul 14, 2023
JulesBelveze
JulesBelveze approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff!

@JulesBelveze JulesBelveze merged commit c3457c0 into release/1.1.0 Jul 14, 2023
3 checks passed
@JulesBelveze JulesBelveze deleted the add-more-robustness-tests-adjectives-age branch July 14, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesBelveze JulesBelveze JulesBelveze approved these changes

Assignees

@alytarik alytarik

@RakshitKhajuria RakshitKhajuria

Labels
⭐ Feature Indicates new feature requests v2.1.0 Issue or request to be done in v2.1.0 release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more robustness tests (adjectives, age)
3 participants
@RakshitKhajuria @JulesBelveze @alytarik