Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: load data in raw format #649

Merged
merged 8 commits into from
Jul 20, 2023
Merged

chore: load data in raw format #649

merged 8 commits into from
Jul 20, 2023

Conversation

JulesBelveze
Copy link
Contributor

@JulesBelveze JulesBelveze commented Jul 19, 2023 •
edited
Loading

This PR aims at enabling data sources to load data into raw format as well as adding tests to the classes.

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@JulesBelveze JulesBelveze self-assigned this Jul 19, 2023
@JulesBelveze JulesBelveze changed the base branch from main to release/1.2.0 July 19, 2023 17:45
@JulesBelveze JulesBelveze linked an issue Jul 20, 2023 that may be closed by this pull request
Add tests for datasets #651
Closed
@ArshaanNazir
Copy link
Collaborator

LGTM @JulesBelveze

@JulesBelveze JulesBelveze merged commit 5298225 into release/1.2.0 Jul 20, 2023
3 checks passed
@JulesBelveze JulesBelveze deleted the chore/load-data-raw branch July 20, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArshaanNazir ArshaanNazir ArshaanNazir approved these changes

Assignees

@JulesBelveze JulesBelveze

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for datasets
2 participants
@JulesBelveze @ArshaanNazir