Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/add random age test #654

Merged
merged 8 commits into from
Jul 24, 2023
Merged

feature/add random age test #654

merged 8 commits into from
Jul 24, 2023

Conversation

alytarik
Copy link
Contributor

@alytarik alytarik commented Jul 20, 2023 •
edited
Loading

Example:
image

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@alytarik alytarik changed the title add random age test DRAFT: add random age test Jul 20, 2023
@alytarik alytarik marked this pull request as ready for review July 24, 2023 07:35
@alytarik alytarik changed the title DRAFT: add random age test feature/add random age test Jul 24, 2023
JulesBelveze
JulesBelveze approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulesBelveze JulesBelveze linked an issue Jul 24, 2023 that may be closed by this pull request
Add more robustness tests (adjectives, age) #531
Closed
@JulesBelveze JulesBelveze merged commit b917bc7 into release/1.2.0 Jul 24, 2023
3 checks passed
@JulesBelveze JulesBelveze deleted the feature/age-tests branch July 24, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesBelveze JulesBelveze JulesBelveze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more robustness tests (adjectives, age)
2 participants
@alytarik @JulesBelveze