Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NER support for HF datasets #673

Merged
merged 12 commits into from
Aug 1, 2023
Merged

NER support for HF datasets #673

merged 12 commits into from
Aug 1, 2023

Conversation

alytarik
Copy link
Contributor

@alytarik alytarik commented Jul 26, 2023 •
edited
Loading

Example Usage and Dataset:
image
image

closes #579

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

@alytarik alytarik marked this pull request as ready for review July 27, 2023 09:48
@JulesBelveze JulesBelveze linked an issue Jul 28, 2023 that may be closed by this pull request
Add NER support for HF datasets #579
Closed
JulesBelveze
JulesBelveze suggested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@JulesBelveze JulesBelveze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Also, could you please add a few lines to the PR description explaining the goal of this PR (even though quite self explanatory).

Also, I think there's a problem with the way you parametrize the test, and that's why it fails.

langtest/datahandler/datasource.py Show resolved Hide resolved
langtest/langtest.py Show resolved Hide resolved
JulesBelveze
JulesBelveze reviewed Jul 31, 2023
View reviewed changes
langtest/datahandler/datasource.py Outdated Show resolved Hide resolved
langtest/datahandler/datasource.py Outdated Show resolved Hide resolved
tests/test_datasource.py Outdated Show resolved Hide resolved
@ArshaanNazir ArshaanNazir merged commit c5611a6 into release/1.2.0 Aug 1, 2023
3 checks passed
@JulesBelveze JulesBelveze deleted the feature/hf-ner-datasets branch August 1, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulesBelveze JulesBelveze JulesBelveze approved these changes

@ArshaanNazir ArshaanNazir Awaiting requested review from ArshaanNazir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NER support for HF datasets
3 participants
@alytarik @JulesBelveze @ArshaanNazir