Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/Accuracy and Fairness for Huggingface (QA and summarization) #811

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix/Accuracy and Fairness for Huggingface (QA and summarization) #811

merged 1 commit into from
Oct 3, 2023

Conversation

Prikshit7766
Copy link
Contributor

@Prikshit7766 Prikshit7766 commented Oct 3, 2023 •
edited

Description

This pull request addresses an issue with the accuracy and fairness testing for Hugging Face question answering and summarization datasets, as well as CSV question answering and summarization datasets.

Changes Made

  • default prompts will be used if when dataset names is None

➤ Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Usage

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

chakravarthik27
chakravarthik27 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@chakravarthik27 chakravarthik27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, add a PR description.

@ArshaanNazir ArshaanNazir merged commit 1ddb836 into release/1.6.0 Oct 3, 2023
3 checks passed
@Prikshit7766 Prikshit7766 self-assigned this Oct 3, 2023
@ArshaanNazir ArshaanNazir deleted the fix/Accuracy/Fairness branch October 4, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chakravarthik27 chakravarthik27 chakravarthik27 approved these changes

Assignees

@Prikshit7766 Prikshit7766

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Prikshit7766 @chakravarthik27 @ArshaanNazir