Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rc errors #868

Merged
merged 23 commits into from
Nov 2, 2023
Merged

fix rc errors #868

merged 23 commits into from
Nov 2, 2023

Conversation

ArshaanNazir
Copy link
Collaborator

Description

Fix errors related to base_hubs

@ArshaanNazir ArshaanNazir changed the title fix base_hub error fix rc errors Nov 2, 2023
@@ -707,8 +704,8 @@ def load_model(cls, path: str):
if isinstance(path, str):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whenever the path is not a string in load_model(), then tokenizer is None

@ArshaanNazir ArshaanNazir merged commit 693a14b into release/1.8.0 Nov 2, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants