Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize qa dataset naming and structure #876

Merged

Conversation

Prikshit7766
Copy link
Contributor

@Prikshit7766 Prikshit7766 commented Nov 7, 2023

Description

This PR addresses the issue of lengthy and unintuitive dataset names, such as "datasetname-test," "datasetname-test-tiny," "datasetname-dev," and "datasetname-dev-tiny." The proposed changes aim to adopt a more concise and informative naming format for better clarity.

To ensure consistency and clarity, this PR suggests standardizing key parameters, including datasource, split, and subset in dataset names. This standardization will make it easier for users to understand and work with the datasets.


Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Usage

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

Screenshots (if appropriate):

@Prikshit7766 Prikshit7766 linked an issue Nov 7, 2023 that may be closed by this pull request
@ArshaanNazir ArshaanNazir merged commit 22b5eb5 into release/1.8.0 Nov 9, 2023
3 checks passed
@Prikshit7766 Prikshit7766 self-assigned this Nov 9, 2023
@ArshaanNazir ArshaanNazir deleted the standardize-qa-dataset-naming-and-structure branch November 16, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize QA Dataset Naming and Structure
3 participants