Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable and update reference to global_service_context #956

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Remove unused variable and update reference to global_service_context #956

merged 4 commits into from
Jan 16, 2024

Conversation

chakravarthik27
Copy link
Collaborator

Description

➤ Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Usage

Checklist:

  • I've added Google style docstrings to my code.
  • I've used pydantic for typing when/where necessary.
  • I have linted my code
  • I have added tests to cover my changes.

Screenshots (if appropriate):

@ArshaanNazir ArshaanNazir merged commit fb8cd42 into release/2.0.0 Jan 16, 2024
3 checks passed
@ArshaanNazir ArshaanNazir deleted the fix/LangtestRetrieverEvaluator branch January 23, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArshaanNazir ArshaanNazir ArshaanNazir approved these changes

Assignees

@chakravarthik27 chakravarthik27

@ArshaanNazir ArshaanNazir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chakravarthik27 @ArshaanNazir