-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add support for other file formats #993
Merged
chakravarthik27
merged 10 commits into
release/2.0.1
from
feature/add-support-for-other-file-formats
Mar 29, 2024
Merged
Feature/add support for other file formats #993
chakravarthik27
merged 10 commits into
release/2.0.1
from
feature/add-support-for-other-file-formats
Mar 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…support-for-other-file-formats
ArshaanNazir
approved these changes
Mar 28, 2024
ArshaanNazir
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix build. @chakravarthik27
ArshaanNazir
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request significantly improves the data source handling capabilities in our
BaseDataset
andDataFactory
classes.Key updates:
Dynamic Data Source Support in BaseDataset: The
__init_subclass__
method of theBaseDataset
class has been improved to dynamically accommodate different data sources based on the class name. When a class name matches a pandas read method (such asread_excel
orread_json
), the class is immediately registered as a data source for the appropriate file extensions. This simplifies the process of adding support for additional data sources by simply defining new subclasses ofBaseDataset
.Enhanced Data Source Mapping in DataFactory: The
DataFactory
class now uses the BaseDataset's data_sources dictionary to instantiate the correct Dataset type based on the file extension. As a result, each data source's class consumption is precisely controlled.These changes improve the flexibility and maintainability of our data processing code. Adding support for new data sources is now easier, requiring simply the creation of new subclasses of
BaseDataset
, eliminating the need for manual modifications to theDataFactory
class.