Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relocating public examples back to the main repository #13292

Merged
merged 7 commits into from Jan 28, 2023
Merged

Relocating public examples back to the main repository #13292

merged 7 commits into from Jan 28, 2023

Conversation

maziyarpanahi
Copy link
Member

@maziyarpanahi maziyarpanahi commented Dec 31, 2022 •
edited

We are relocating all examples related to the public Spark NLP back to the example directory. The reasons resulting for this decision:

  • It is reasonable to have some examples under the example directory like many other libraries
  • The public examples are abandoned in the spark-nlp-workshop and not maintain by any specific team
  • The spark-nlp-workshop has become extremely hard to navigate. It's not easy for a new user to know where to start and I don't see any sign it will get any better
  • Having all our examples in main repository will allow us to have them all compatible in each release (versioning them as well via tag)
  • This also encourages us to have more examples for different languages as the people maintaining workshop mostly know Python

@maziyarpanahi maziyarpanahi added documentation new-feature Introducing a new feature DON'T MERGE Do not merge this PR labels Dec 31, 2022
@maziyarpanahi maziyarpanahi changed the base branch from master to release/430-release-candidate December 31, 2022 07:56
@maziyarpanahi maziyarpanahi mentioned this pull request Dec 31, 2022
Merged
@maziyarpanahi maziyarpanahi merged commit 9756a7e into release/430-release-candidate Jan 28, 2023
@maziyarpanahi maziyarpanahi mentioned this pull request Jan 28, 2023
Merged
josejuanmartinez pushed a commit that referenced this pull request Feb 17, 2023
@maziyarpanahi
Relocating public examples back to the main repository (#13292)
fd0788a 
* First init of relocating examples

* Add Scala examples

* Rename offline notebook

* Fix a bad import

* remove outdated example

* Create text, image, and audio categories

* Example codes for configs should be language agnostic
josejuanmartinez pushed a commit that referenced this pull request Feb 17, 2023
@maziyarpanahi
Relocating public examples back to the main repository (#13292)
c3e0cd8 
* First init of relocating examples

* Add Scala examples

* Rename offline notebook

* Fix a bad import

* remove outdated example

* Create text, image, and audio categories

* Example codes for configs should be language agnostic
@KshitizGIT KshitizGIT deleted the SPARKNLP-711-move-all-examples-from-spark-nlp-workshop-to-spark-nlp-examples branch March 2, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation DON'T MERGE Do not merge this PR new-feature Introducing a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@maziyarpanahi