CoNLLGenerator Bugfixes and Improvements both on Scala and Python #13051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata field to use as sentence for CoNLL Generation
…supporting scala overloaded methods), Python Tests for 2 and 3 arguments
maziyarpanahi
changed the base branch from
release/423-release-candidate
to
SPARKNLP-645-fix-a-bug-in-co-nll-generator-annotator
maziyarpanahi
approved these changes
Nov 9, 2022
maziyarpanahi
merged commit a456407
into
JohnSnowLabs:SPARKNLP-645-fix-a-bug-in-co-nll-generator-annotator
maziyarpanahi
added a commit
that referenced
this pull request
Nov 10, 2022
* SPARKNLP-645 Update unit tests for CoNLLGenerator * CoNLLGenerator Bugfixes and Improvements both on Scala and Python (#13051) * Test for non-int metadata values in CoNLLGenerator * Fix for non-int metadata values bug in CoNLLGenerator * Include escaping when writing csv in order to preserve special char tokens * Remove unnecessary option from csv write * Addin metadata sentence key parameter in order to selecti which metadata field to use as sentence for CoNLL Generation * Minor formatting in scala, Python refactorization (several bug fixes supporting scala overloaded methods), Python Tests for 2 and 3 arguments Co-authored-by: Andres Fernandez <51669244+jfernandrezj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test for non-int metadata values in CoNLLGenerator
Fix for non-int metadata values bug in CoNLLGenerator
Include escaping when writing csv in order to preserve special char tokens
Remove unnecessary option from csv write
Adding metadata sentence key parameter in order to select which metadata field to use as sentence for CoNLL Generation
Minor formatting in scala, Python refactorization (several bug fixes supporting scala overloaded methods), Python Tests for 2 and 3 arguments
Motivation and Context
Issue 13004
How Has This Been Tested?
Tested existing Projects using the 2 arguments alternative (the only one supported so far)
Created new tests to test this functionality
Screenshots (if appropriate):
Types of changes
Checklist: