Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Chore: conda recipe update #13764

Merged

Conversation

luca-martial
Copy link
Contributor

Description

Updating the conda recipe to make releases easier and faster to create.

Motivation and Context

Instead of building separate python package files, a single one is created when using noarch: python
This makes it more simple/fast to run, test & upload builds.

Tests have also been added, and other fields have been modified to comply with conda-forge requirements in case you would like to upload the package to the conda-forge channel.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@luca-martial
Copy link
Contributor Author

@maziyarpanahi let me know if this is of any use, I'm also not sure which branch to make this PR for, probably better to wait once you have a release branch ready

@luca-martial luca-martial changed the title Chore: conda recipe update Draft: Chore: conda recipe update Apr 21, 2023
@maziyarpanahi
Copy link
Member

@maziyarpanahi let me know if this is of any use, I'm also not sure which branch to make this PR for, probably better to wait once you have a release branch ready

This is extremely useful! Thank you for the initiative and the master branch is a good one to base it on.

@maziyarpanahi maziyarpanahi changed the base branch from master to release/500-release-candidate July 3, 2023 08:34
@maziyarpanahi maziyarpanahi merged commit b962451 into release/500-release-candidate Jul 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants