Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tapas bug due to exceeding the maximum rank value #13772

Merged

Conversation

vankov
Copy link
Contributor

@vankov vankov commented Apr 27, 2023

A bug fix for the Tapas model.

Description

The problem is that the maximum value rank in Tapas is limited to 255 and if the text is long enough you may end up with higher ranks. The solution is to replace ranks higher than 255 with 255.

Motivation and Context

The issue was reported by a user in the slack channel. If you feed a long text (i.e table) you may end up with ranks higher than 255 and this is the max value allowed by the model (perhaps they used a byte variable to represent it or a static array). Such ranks case a Tensorflow exception.

How Has This Been Tested?

I first reproduced the problem by running Tapas on long enough texts and made sure that the fixes solves the problem

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vankov vankov changed the title Fix tapas max col rank issue Fix Tapas bug due to exceeding the maximum rank value Apr 27, 2023
@maziyarpanahi maziyarpanahi self-assigned this Apr 27, 2023
@maziyarpanahi maziyarpanahi self-requested a review April 27, 2023 13:18
@maziyarpanahi maziyarpanahi added bug-fix DON'T MERGE Do not merge this PR labels Apr 27, 2023
@maziyarpanahi maziyarpanahi changed the base branch from master to release/442-release-candidate May 10, 2023 09:13
@maziyarpanahi maziyarpanahi merged commit 7b2674e into release/442-release-candidate May 10, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix DON'T MERGE Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants