Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKNLP-832-MultiDateMatcher-doesn-t-return-multiple-dates #13783

Conversation

danilojsl
Copy link
Contributor

@danilojsl danilojsl commented May 4, 2023

Description

This change modifies the code to support the scenario where a text has multiple dates content.
It adds setRelaxedFactoryStrategy parameter to allow the users to choose the matching strategy bases on their use cases.

Motivation and Context

To solve a bug that only outputs one date regardless of the number of dates presented in a text

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl added DON'T MERGE Do not merge this PR bug-fix labels May 4, 2023
@maziyarpanahi maziyarpanahi self-assigned this May 10, 2023
@maziyarpanahi maziyarpanahi changed the base branch from master to release/442-release-candidate May 10, 2023 11:08
@maziyarpanahi maziyarpanahi merged commit 2153a06 into release/442-release-candidate May 10, 2023
7 of 8 checks passed
@maziyarpanahi maziyarpanahi linked an issue May 18, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix DON'T MERGE Do not merge this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MultiDateMatcher doesn't return more than one date
2 participants